[webkit-reviews] review granted: [Bug 216739] Selection API: Further improvements to VisibleSelection, FrameSelection, and DOMSelection to preserve anchor and focus : [Attachment 409222] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 216739: Selection API: Further improvements to VisibleSelection,
FrameSelection, and DOMSelection to preserve anchor and focus
https://bugs.webkit.org/show_bug.cgi?id=216739

Attachment 409222: Patch

https://bugs.webkit.org/attachment.cgi?id=409222&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 409222
  --> https://bugs.webkit.org/attachment.cgi?id=409222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409222&action=review

Looks like editing/execCommand/insert-list-nested-with-orphaned.html is failing
legitimately.

> Source/WebCore/editing/VisibleSelection.cpp:234
> +    m_baseIsFirst = m_base <= m_extent;

We may need to take care of the case when m_base / m_extent turns until null
even though m_anchor / m_focus aren't null.