[webkit-reviews] review granted: [Bug 216590] [WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec : [Attachment 408878] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 16 00:02:43 PDT 2020


youenn fablet <youennf at gmail.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 216590: [WebIDL] Move navigator.cookieEnabled to its own interface mixin,
matching the spec
https://bugs.webkit.org/show_bug.cgi?id=216590

Attachment 408878: Patch

https://bugs.webkit.org/attachment.cgi?id=408878&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 408878
  --> https://bugs.webkit.org/attachment.cgi?id=408878
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408878&action=review

> Source/WebCore/page/Navigator.idl:28
> +    // FIXME: Remove this. WebKit is the only engine that still has this.

we could create a bugzilla for it.

> Source/WebCore/page/Navigator.idl:36
> +Navigator includes NavigatorCookies;

Should probably be the first includes to keep lexical order.


More information about the webkit-reviews mailing list