[webkit-reviews] review granted: [Bug 216584] OfflineAudioContext constructor should not throw when given a bad buffer length : [Attachment 408875] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 216584: OfflineAudioContext constructor should not throw when given a bad
buffer length
https://bugs.webkit.org/show_bug.cgi?id=216584

Attachment 408875: Patch

https://bugs.webkit.org/attachment.cgi?id=408875&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 408875
  --> https://bugs.webkit.org/attachment.cgi?id=408875
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408875&action=review

> Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp:44
> +OfflineAudioDestinationNode::OfflineAudioDestinationNode(BaseAudioContext&
context, unsigned numberOfChannels, AudioBuffer* renderTarget)

could be a RefPtr<AudioBuffer>&&?

> Source/WebCore/Modules/webaudio/WebKitOfflineAudioContext.cpp:39
> +inline WebKitOfflineAudioContext::WebKitOfflineAudioContext(Document&
document, Ref<AudioBuffer>&& renderTarget)

inline not needed