[webkit-reviews] review granted: [Bug 216425] Add proper support for AudioContextOptions.sampleRate : [Attachment 408581] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 216425: Add proper support for AudioContextOptions.sampleRate
https://bugs.webkit.org/show_bug.cgi?id=216425

Attachment 408581: Patch

https://bugs.webkit.org/attachment.cgi?id=408581&action=review




--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 408581
  --> https://bugs.webkit.org/attachment.cgi?id=408581
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408581&action=review

Can we enable or add tests for AudioContextOptions.sampleRate?

> Source/WebCore/ChangeLog:8
> +	   Add proper support for AudioContextOptions.sampleRate. Previously,
our AudioContext always run

s/always run/always ran/

> Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:-86
> -    float hardwareSampleRate = AudioDestination::hardwareSampleRate();
> -    LOG(WebAudio, ">>>> hardwareSampleRate = %f\n", hardwareSampleRate);

Is this needed now?