[webkit-reviews] review granted: [Bug 216224] [JSC] Canonicalize "true" unicode extension type value to "" : [Attachment 408582] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted  review:
Bug 216224: [JSC] Canonicalize "true" unicode extension type value to ""
https://bugs.webkit.org/show_bug.cgi?id=216224

Attachment 408582: Patch

https://bugs.webkit.org/attachment.cgi?id=408582&action=review




--- Comment #10 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 408582
  --> https://bugs.webkit.org/attachment.cgi?id=408582
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408582&action=review

r=me

> Source/JavaScriptCore/runtime/IntlObject.cpp:193
> +static Vector<StringView> unicodeExtensionSubTags(StringView extension)

nit: Since we're moving this anyway, could we rename it unicodeExtensionSubtags
with a lowercase t?

...or rather, maybe unicodeExtensionComponents, since that's what it's been
renamed to:
https://tc39.es/ecma402/#sec-unicode-extension-components

> Source/JavaScriptCore/runtime/IntlObject.cpp:293
> +	   if (subtag.length() != 2) {
> +	       ++index;
> +	       continue;
> +	   }

Is this just for the leading attribute case?