[webkit-reviews] review granted: [Bug 216414] Consolidate BaseDateAndTimeInputType and BaseChooserOnlyDateAndTimeInputType : [Attachment 408551] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 216414: Consolidate BaseDateAndTimeInputType and
BaseChooserOnlyDateAndTimeInputType
https://bugs.webkit.org/show_bug.cgi?id=216414

Attachment 408551: Patch

https://bugs.webkit.org/attachment.cgi?id=408551&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 408551
  --> https://bugs.webkit.org/attachment.cgi?id=408551
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408551&action=review

r=me

> Source/WebCore/html/BaseDateAndTimeInputType.cpp:312
> +	   return;
> +    DateTimeChooserParameters parameters;

NIT: I'd add a newline here

> Source/WebCore/html/BaseDateAndTimeInputType.h:46
> +enum class DateTimeFormatValidationResults : uint8_t {

NIT: should this be inside `BaseDateAndTimeInputType` instead of in the
`WebCore` namespace?

> Source/WebCore/html/DateTimeLocalInputType.h:42
> +	   : BaseDateAndTimeInputType(element) { }

Style: the `{ }` should probably be on separate lines too if the constructor is
more than one line

> Source/WebCore/html/MonthInputType.h:42
> +	   : BaseDateAndTimeInputType(element) { }

ditto (DateTimeLocalInputType.h:42)

> Source/WebCore/html/WeekInputType.h:42
> +	   : BaseDateAndTimeInputType(element) { }

ditto (DateTimeLocalInputType.h:42)