[webkit-reviews] review granted: [Bug 216397] [GTK] Timeouts after reftest-wait class enablement in r266817 : [Attachment 408530] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 216397: [GTK] Timeouts after reftest-wait class enablement in r266817
https://bugs.webkit.org/show_bug.cgi?id=216397

Attachment 408530: Patch

https://bugs.webkit.org/attachment.cgi?id=408530&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 408530
  --> https://bugs.webkit.org/attachment.cgi?id=408530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408530&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:1971
> +	   RunLoop::current().dispatchAfter(1_ms, [] {

Usually we frown upon timers in testing code, but given that the reason
here is to make sure other things run and that the timeout is small and
unlikely to cause tests to run more slowly, I am willing to accept this
=]