[webkit-reviews] review granted: [Bug 216280] REGRESSION(r266681) [GTK] constexpr build failure in LTS/Debian with GCC 8 : [Attachment 408256] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 12:52:14 PDT 2020


Darin Adler <darin at apple.com> has granted Lauro Moura <lmoura at igalia.com>'s
request for review:
Bug 216280: REGRESSION(r266681) [GTK] constexpr build failure in LTS/Debian
with GCC 8
https://bugs.webkit.org/show_bug.cgi?id=216280

Attachment 408256: Patch

https://bugs.webkit.org/attachment.cgi?id=408256&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 408256
  --> https://bugs.webkit.org/attachment.cgi?id=408256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408256&action=review

> Source/WebCore/platform/text/TextCodecSingleByte.cpp:248
> +    default:
> +	   RELEASE_ASSERT_NOT_REACHED();

I guess we can do this. But sadly this has a side effect of suppressing the
compile-time warning if we forget to include one of the enumeration values
here. Would be nice to find a solution that does not do that.


More information about the webkit-reviews mailing list