[webkit-reviews] review granted: [Bug 216255] [WebIDL] Add support for partial interface mixins : [Attachment 408254] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 216255: [WebIDL] Add support for partial interface mixins
https://bugs.webkit.org/show_bug.cgi?id=216255

Attachment 408254: Patch

https://bugs.webkit.org/attachment.cgi?id=408254&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 408254
  --> https://bugs.webkit.org/attachment.cgi?id=408254
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408254&action=review

> Source/WebCore/ChangeLog:35
> +	   Move logic to avoid genertion of mixins and partial here.

generation typo here

> Source/WebCore/bindings/scripts/CodeGenerator.pm:212
> +    ${cppName} at every build. This file must not be tried to compile.

You replicated the tortured grammar: "This file must not be tried to compile."
Let's just leave that worthless sentence out?