[webkit-reviews] review granted: [Bug 204673] [GStreamer] Convert custom GObject subclasses to WEBKIT_DEFINE_TYPE : [Attachment 407980] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 204673: [GStreamer] Convert custom GObject subclasses to WEBKIT_DEFINE_TYPE
https://bugs.webkit.org/show_bug.cgi?id=204673

Attachment 407980: Patch

https://bugs.webkit.org/attachment.cgi?id=407980&action=review




--- Comment #4 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 407980
  --> https://bugs.webkit.org/attachment.cgi?id=407980
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407980&action=review

LGTM, just a nit, valid for all new calls of WEBKIT_DEFINE_TYPE:

>
Source/WebCore/platform/graphics/gstreamer/eme/WebKitThunderDecryptorGStreamer.
cpp:65
> +WEBKIT_DEFINE_TYPE(WebKitMediaThunderDecrypt, webkit_media_thunder_decrypt,
WEBKIT_TYPE_MEDIA_CENC_DECRYPT);

I think there's no need for ending ;