[webkit-reviews] review denied: [Bug 216120] [GLIB] RemoteInspectorServer is not started if WebKitWebContext is not created already created : [Attachment 407990] patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 216120: [GLIB] RemoteInspectorServer is not started if WebKitWebContext is
not created already created
https://bugs.webkit.org/show_bug.cgi?id=216120

Attachment 407990: patch

https://bugs.webkit.org/attachment.cgi?id=407990&action=review




--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 407990
  --> https://bugs.webkit.org/attachment.cgi?id=407990
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407990&action=review

> Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp:122
> +    webkitInitialize();

WebKitCookieManager can only be crated by a WebKitWebsiteDataManager, so at
this point the init has already been called for sure. The user can't create a
WebKitCookieManager.

> Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp:77
> +    webkitInitialize();

WebKitFaviconDatabase can only be crated by a WebKitWebContext, so at this
point the init has already been called for sure. The user can't create a
WebKitFaviconDatabase.

> Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp:35
> +#if !PLATFORM(COCOA)

You don't need this, cocoa based ports never build this file.

> Source/WebKit/UIProcess/API/glib/WebKitInitialize.h:32
> +};

Trailing ; is not needed here.