[webkit-reviews] review granted: [Bug 215948] [ews] Notify bot watchers about pre-existing and flaky test failures for JSC tests : [Attachment 407958] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 215948: [ews] Notify bot watchers about pre-existing and flaky test
failures for JSC tests
https://bugs.webkit.org/show_bug.cgi?id=215948

Attachment 407958: Patch

https://bugs.webkit.org/attachment.cgi?id=407958&action=review




--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 407958
  --> https://bugs.webkit.org/attachment.cgi?id=407958
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407958&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1781
> +    def send_email_for_flaky_failure(self, test_name):

Same deal as https://bugs.webkit.org/show_bug.cgi?id=215949, the only
variability here seems to be the suite, should we consider basing all of these
analysis steps on the same base class?