[webkit-reviews] review granted: [Bug 216177] Web Inspector: Incorrect decimal separator in Network web inspector : [Attachment 408000] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 11:31:03 PDT 2020


Brian Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 216177: Web Inspector: Incorrect decimal separator in Network web inspector
https://bugs.webkit.org/show_bug.cgi?id=216177

Attachment 408000: Patch

https://bugs.webkit.org/attachment.cgi?id=408000&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 408000
  --> https://bugs.webkit.org/attachment.cgi?id=408000
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408000&action=review

r=me

> Source/WebInspectorUI/ChangeLog:9
> +	       to be correctly formatted for the locale.

Nit: we don't indent into paragraphs in Changelogs.

> Source/WebInspectorUI/ChangeLog:19
> +	       bytes into localized strings.

Ditto.

> Source/WebInspectorUI/UserInterface/Views/ResourceSizesContentView.css:85
> +    font-variant-caps: petite-caps;

Hah, nice.


More information about the webkit-reviews mailing list