[webkit-reviews] review granted: [Bug 218328] Add some logging to SequenceCheckerImpl::IsCurrent : [Attachment 412629] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 218328: Add some logging to SequenceCheckerImpl::IsCurrent
https://bugs.webkit.org/show_bug.cgi?id=218328

Attachment 412629: Patch

https://bugs.webkit.org/attachment.cgi?id=412629&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 412629
  --> https://bugs.webkit.org/attachment.cgi?id=412629
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412629&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/synchronization/sequence_che
cker.cc:63
> +    if (valid_queue_ != current_queue)
> +	 RTC_LOG(LS_ERROR) << "SequenceCheckerImpl queue check is failing";
>      return valid_queue_ == current_queue;
>    }
>    if (valid_system_queue_ && valid_system_queue_ == current_system_queue) {
> +    if (valid_queue_ != current_queue)
> +	 RTC_LOG(LS_ERROR) << "SequenceCheckerImpl system queue check is
failing";
>      return true;
>    }
> -  return rtc::IsThreadRefEqual(valid_thread_, current_thread);
> +  auto result = rtc::IsThreadRefEqual(valid_thread_, current_thread);
> +  if (!result)
> +    RTC_LOG(LS_ERROR) << "SequenceCheckerImpl thread check is failing";

Would it be helpful have unique log strings to help identify which check fails?