[webkit-reviews] review granted: [Bug 218070] [WebAuthn] Make WebContent process talk to the WebAuthn process for WebAuthn requests : [Attachment 412069] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 218070: [WebAuthn] Make WebContent process talk to the WebAuthn process for
WebAuthn requests
https://bugs.webkit.org/show_bug.cgi?id=218070

Attachment 412069: Patch

https://bugs.webkit.org/attachment.cgi?id=412069&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 412069
  --> https://bugs.webkit.org/attachment.cgi?id=412069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412069&action=review

I had a few suggestions, but looks good. r=me

> Source/WebKit/Scripts/process-entitlements.sh:317
> +#	elif [[ "${PRODUCT_NAME}" == com.apple.WebKit.WebAuthn ]]; then
ios_family_process_webauthn_entitlements

Did you mean to have this commented out?

If so, please include a # FIXME() comment with the bug number to enable it.

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:168
> +    // If so, continue to the old route. Otherwise, use the modern WebAuthn
process way.

I suggest a FIXME bug here to remove this code once we cut-over to the modern
WebAuthn process.