[webkit-reviews] review granted: [Bug 218206] [Mac] Audio and Video element creation up to 300x slower than other browsers : [Attachment 412353] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 218206: [Mac] Audio and Video element creation up to 300x slower than other
browsers
https://bugs.webkit.org/show_bug.cgi?id=218206

Attachment 412353: Patch

https://bugs.webkit.org/attachment.cgi?id=412353&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 412353
  --> https://bugs.webkit.org/attachment.cgi?id=412353
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412353&action=review

> Source/WebCore/platform/audio/mac/AudioSessionMac.mm:104
> +    bool hasSampleRateObserver { false };
> +    Optional<double> sampleRate;
> +    bool hasBufferSizeObserver { false };
> +    Optional<size_t> bufferSize;

Nit: the object would be slightly smaller if the `Optional<size_t>` were
declared above the bools