[webkit-reviews] review granted: [Bug 218202] [LFC] Do not use RenderStyle padding values unless padding is set : [Attachment 412351] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 26 14:26:20 PDT 2020
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 218202: [LFC] Do not use RenderStyle padding values unless padding is set
https://bugs.webkit.org/show_bug.cgi?id=218202
Attachment 412351: Patch
https://bugs.webkit.org/attachment.cgi?id=412351&action=review
--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 412351
--> https://bugs.webkit.org/attachment.cgi?id=412351
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412351&action=review
> Source/WebCore/ChangeLog:9
> + An unset padding value computes to the passed in maximum value.
> + (e.g. valueForLength(style.paddingLeft(), 10) -> computed padding
left is 10px)
Unset padding should be 0. Which test is this failing?
More information about the webkit-reviews
mailing list