[webkit-reviews] review granted: [Bug 217491] [GPU Process] Use correct GPU runtime settings when creating the dynamic IOKit sandbox extensions for the WebContent process : [Attachment 410882] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 217491: [GPU Process] Use correct GPU runtime settings when creating the
dynamic IOKit sandbox extensions for the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=217491

Attachment 410882: Patch

https://bugs.webkit.org/attachment.cgi?id=410882&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 410882
  --> https://bugs.webkit.org/attachment.cgi?id=410882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410882&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:486
> +	   ||
!m_defaultPageGroup->preferences().captureVideoInGPUProcessEnabled()

We can also capture in UIProcess, in which case we might not need the
gpuIOKitExtensionHandles for capture purposes.