[webkit-reviews] review granted: [Bug 217383] Add support for MediaRecorder bitrate getters : [Attachment 410820] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 217383: Add support for MediaRecorder bitrate getters
https://bugs.webkit.org/show_bug.cgi?id=217383

Attachment 410820: Patch

https://bugs.webkit.org/attachment.cgi?id=410820&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 410820
  --> https://bugs.webkit.org/attachment.cgi?id=410820
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410820&action=review

>>> Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104
>>> +	     options.audioBitsPerSecond = 192000;
>> 
>> Where do these numbers come from?
> 
> The spec says to choose decent defaults.
> These are values for quality recording of audio and video.
> They could be set lower.
> 
> Firefox is using 128kbps/2.5mbps which is not too far. Not sure about Chrome.

It might be helpful for someone looking at this later to have a named constant.

> Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:106
> +	   options.videoBitsPerSecond = 10000000;

Ditto