[webkit-reviews] review granted: [Bug 191310] Add onslotchange on ShadowRoot, SVG, and HTML elements : [Attachment 410337] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Tetsuharu Ohzeki
<tetsuharu.ohzeki at gmail.com>'s request for review:
Bug 191310: Add onslotchange on ShadowRoot, SVG, and HTML elements
https://bugs.webkit.org/show_bug.cgi?id=191310

Attachment 410337: Patch

https://bugs.webkit.org/attachment.cgi?id=410337&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 410337
  --> https://bugs.webkit.org/attachment.cgi?id=410337
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410337&action=review

Looks okay to me but your change logs need some work.

> Source/WebCore/ChangeLog:7
> +

Could you add a description here?

> Source/WebCore/ChangeLog:9
> +	   Tests:
> +	       imported/w3c/web-platform-tests/dom/idlharness.window.html:

This isn't right. The first test name should appear after "Tests:" followed by
a single space,
and the subsequent lines should appear aligned to that line:
e.g.
	  Tests: imported/w3c/web-platform-tests/dom/idlharness.window.html
		
imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-
all-global-events.html
...

> LayoutTests/ChangeLog:7
> +

Say that you've rebaselined tests now that more test cases are passing.

> LayoutTests/imported/w3c/ChangeLog:7
> +

Ditto.