[webkit-reviews] review granted: [Bug 217261] [JSC] Introduce JITOperationList to validate JIT-caged pointers : [Attachment 410398] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 217261: [JSC] Introduce JITOperationList to validate JIT-caged pointers
https://bugs.webkit.org/show_bug.cgi?id=217261

Attachment 410398: Patch

https://bugs.webkit.org/attachment.cgi?id=410398&action=review




--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 410398
  --> https://bugs.webkit.org/attachment.cgi?id=410398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410398&action=review

r=me

> Source/JavaScriptCore/assembler/JITOperationList.h:50
> +    JS_EXPORT_PRIVATE static void populatePointersInEmbedder1(const
uintptr_t* beginHost, const uintptr_t* endHost, const uintptr_t*
beginOperations, const uintptr_t* endOperations);
> +    JS_EXPORT_PRIVATE static void populatePointersInEmbedder2(const
uintptr_t* beginHost, const uintptr_t* endHost, const uintptr_t*
beginOperations, const uintptr_t* endOperations);

let's do what we  talked  about on slack of just a  single function

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:380
> +    WebCore::populateJITOperations();

could we have a version of "initialize" per library that calls the necessary
initialize functions blow it?

e.g, JSC::initialize,
WebCore::initilziae, that calls JSC::initialize and calls
WebCore::populateJITOperations
WebKit::initialize, that calls WebCore::initialize, and
WebKit::populateJITOperations