[webkit-reviews] review granted: [Bug 217198] Support EXT_texture_compression_rgtc WebGL extension : [Attachment 410383] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Darpinian
<jdarpinian at chromium.org>'s request for review:
Bug 217198: Support EXT_texture_compression_rgtc WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=217198

Attachment 410383: Patch

https://bugs.webkit.org/attachment.cgi?id=410383&action=review




--- Comment #4 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 410383
  --> https://bugs.webkit.org/attachment.cgi?id=410383
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410383&action=review

Looks great! One question. r+

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:6739
> +	   const int kBlockHeight = 4;

Have you confirmed that these values (from the extension spec) are correct, and
that the tests both successfully enable the extension, and pass?