[webkit-reviews] review granted: [Bug 216793] [Contact Picker API] Introduce bindings for the Contact Picker API : [Attachment 410369] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 2 15:55:52 PDT 2020

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 216793: [Contact Picker API] Introduce bindings for the Contact Picker API

Attachment 410369: Patch


--- Comment #12 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 410369
  --> https://bugs.webkit.org/attachment.cgi?id=410369

View in context: https://bugs.webkit.org/attachment.cgi?id=410369&action=review

Looks good overall! I think we might need a clean build for Win EWS though.

> LayoutTests/contact-picker/contacts-interfaces.html:22
> +	       shouldBeTrue("navigator.contacts.select(['name', 'email'],
{multiple: true}) instanceof Promise");

I think it would be nice to test a few additional corner cases, like calling
select with some strings that don’t map to enum values, or even non-strings, or
an empty array, or passing in invalid ContactsSelectOptions.

More information about the webkit-reviews mailing list