[webkit-reviews] review granted: [Bug 217229] [macOS] Enable date, time, and datetime-local input types : [Attachment 410356] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 2 13:25:41 PDT 2020
Sam Weinig <sam at webkit.org> has granted Aditya Keerthi <akeerthi at apple.com>'s
request for review:
Bug 217229: [macOS] Enable date, time, and datetime-local input types
https://bugs.webkit.org/show_bug.cgi?id=217229
Attachment 410356: Patch
https://bugs.webkit.org/attachment.cgi?id=410356&action=review
--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 410356
--> https://bugs.webkit.org/attachment.cgi?id=410356
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=410356&action=review
> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:304
> - "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
> + "!PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
> default: false
Lol, I made this way more confusing than I intended to. Should probably switch
these to:
"PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false
default: true
Right?
More information about the webkit-reviews
mailing list