[webkit-reviews] review granted: [Bug 217246] TranslateTransformOperation shouldn't take in a FloatSize to convert z as a double : [Attachment 410358] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 217246: TranslateTransformOperation shouldn't take in a FloatSize to
convert z as a double
https://bugs.webkit.org/show_bug.cgi?id=217246

Attachment 410358: Patch

https://bugs.webkit.org/attachment.cgi?id=410358&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 410358
  --> https://bugs.webkit.org/attachment.cgi?id=410358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410358&action=review

> Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h:53
> +    double xAsDouble(const FloatSize& borderBoxSize) const { return
floatValueForLength(m_x, borderBoxSize.width()); }
> +    double yAsDouble(const FloatSize& borderBoxSize) const { return
floatValueForLength(m_y, borderBoxSize.height()); }
> +    double zAsDouble() const { return floatValueForLength(m_z, 1); }

Strange mix here. We are calling something that computes a float, then
converting it to a double when returning it, then it seems 2 of the 3 call
sites call narrowPrecisionToFloat on a value that was just converted *from* a
float. Maybe this should return float, not double?