[webkit-reviews] review granted: [Bug 219299] [ANGLE] Convert adjust-angle-include-paths.sh to a Python script for Windows without Cygwin : [Attachment 414913] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 219299: [ANGLE] Convert adjust-angle-include-paths.sh to a Python script
for Windows without Cygwin
https://bugs.webkit.org/show_bug.cgi?id=219299

Attachment 414913: Patch

https://bugs.webkit.org/attachment.cgi?id=414913&action=review




--- Comment #3 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 414913
  --> https://bugs.webkit.org/attachment.cgi?id=414913
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414913&action=review

Looks fine with one piece of feedback on the copyright. r+

> Source/ThirdParty/ANGLE/adjust-angle-include-paths.py:3
> +# Copyright (C) 2020 Sony Interactive Entertainment Inc.

I'm not sure how appropriate it is to put Sony's copyright on this script, with
no license, given that it's a port of a script written by myself and others
which previously didn't have one. May I suggest either removing this, or
putting the full WebKit copyright stanza and adding all of the contributor
companies (Google, Apple, Igalia, and now Sony)?