[webkit-reviews] review granted: [Bug 219310] [LFC Display] Fix box locations for positioned elements : [Attachment 414960] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 27 14:26:37 PST 2020

zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 219310: [LFC Display] Fix box locations for positioned elements

Attachment 414960: Patch


--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 414960
  --> https://bugs.webkit.org/attachment.cgi?id=414960

View in context: https://bugs.webkit.org/attachment.cgi?id=414960&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:233
> +    return isInitialContainingBlock() || isPositioned() ||

I'd change it to return isPositioned() || isContainingBlockForFixedPosition();
-which makes it quite clear that fixed positioning is a type of out-of-flow.

More information about the webkit-reviews mailing list