[webkit-reviews] review granted: [Bug 219061] [WebGL2] Rasterizer discard interferes with implicit clears : [Attachment 414717] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 23 13:33:12 PST 2020
Dean Jackson <dino at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 219061: [WebGL2] Rasterizer discard interferes with implicit clears
https://bugs.webkit.org/show_bug.cgi?id=219061
Attachment 414717: Patch
https://bugs.webkit.org/attachment.cgi?id=414717&action=review
--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 414717
--> https://bugs.webkit.org/attachment.cgi?id=414717
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=414717&action=review
> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:467
> + : m_context(context), m_wasEnabled(wasEnabled)
Nit: we do this on two lines.
> Source/WebCore/html/canvas/WebGLRenderingContextBase.h:650
> + bool m_rasterizerDiscardEnabled;
Not necessary now, but we should probably go through these and give them
default values.
More information about the webkit-reviews
mailing list