[webkit-reviews] review granted: [Bug 219262] Introduce new display list meta commands in preparation for webkit.org/b/219091 : [Attachment 414811] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 219262: Introduce new display list meta commands in preparation for
webkit.org/b/219091
https://bugs.webkit.org/show_bug.cgi?id=219262

Attachment 414811: Patch

https://bugs.webkit.org/attachment.cgi?id=414811&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 414811
  --> https://bugs.webkit.org/attachment.cgi?id=414811
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414811&action=review

> Source/WebCore/ChangeLog:18
> +	   `MetaCommandEndOfDisplayList` is used to inform the replayer that it
should expect no more display list items;

Why not just MetaCommandEnd. OfDisplayList seems redundant.
Or maybe MetaCommandPause or MetaCommandWait since we can receive more display
list items in the future.

> Source/WebCore/ChangeLog:24
> +	   by `MetaCommandSwitchToItemBuffer` items; finally, it will conclude
with a `MetaCommandEndOfDisplayList` item.

Change we should rename this to MetaCommandChangeItemBuffer to be consistent
although this is really more like MetaCommandContinueInNewItemBuffer.