[webkit-reviews] review granted: [Bug 219207] Remove DataDetectorType::None, it's not appropriate for a enum used as an OptionSet : [Attachment 414689] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 20 10:02:34 PST 2020


Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 219207: Remove DataDetectorType::None, it's not appropriate for a enum used
as an OptionSet
https://bugs.webkit.org/show_bug.cgi?id=219207

Attachment 414689: Patch

https://bugs.webkit.org/attachment.cgi?id=414689&action=review




--- Comment #2 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 414689
  --> https://bugs.webkit.org/attachment.cgi?id=414689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414689&action=review

> Source/WebCore/page/Settings.yaml:97
> +	 default: static_cast<DataDetectorType>(0)

Not sure how this is turned into C++ but I wonder if it's possible to make it
be { } ?


More information about the webkit-reviews mailing list