[webkit-reviews] review denied: [Bug 218893] [WebAuthn] Implement SPI for AuthenticationServices.Framework : [Attachment 414661] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 218893: [WebAuthn] Implement SPI for AuthenticationServices.Framework
https://bugs.webkit.org/show_bug.cgi?id=218893

Attachment 414661: Patch

https://bugs.webkit.org/attachment.cgi?id=414661&action=review




--- Comment #29 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 414661
  --> https://bugs.webkit.org/attachment.cgi?id=414661
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414661&action=review

Getting closer.

> Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorSelectionCriteria.h:46
> +/*!@discussion The default value is NO.*/

I think an empty line before this would be good.

> Source/WebKit/UIProcess/API/Cocoa/_WKAuthenticatorSelectionCriteria.h:48
> +/*!@discussion The default value is
_WKUserVerificationRequirementPreferred.*/

ditto

> Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.h:52
> +- (instancetype)initWithRp:(_WKPublicKeyCredentialRpEntity *)rp
user:(_WKPublicKeyCredentialUserEntity *)user
pubKeyCredParams:(NSArray<_WKPublicKeyCredentialParameters *>
*)pubKeyCredParams;

pubKeyCredParams -> publicKeyCredentialParamaters
What is Rp?  I think that should be spelled out also.  Here and everywhere.

> Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialCreationOptions.h:62
> +/*!@discussion The default value is
_WKAttestationConveyancePreferenceNone.*/

empty line before

> Source/WebKit/UIProcess/API/Cocoa/_WKPublicKeyCredentialRequestOptions.h:42
> + at property (nullable, nonatomic, copy) NSString *rpId;

Whatever rp is, then identifier.