[webkit-reviews] review denied: [Bug 218515] Web Inspector: Underline active font-face(s) in Elements sidebar Styles panel : [Attachment 414485] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 19 09:10:51 PST 2020


Antti Koivisto <koivisto at iki.fi> has denied Patrick Angle <pangle at apple.com>'s
request for review:
Bug 218515: Web Inspector: Underline active font-face(s) in Elements sidebar
Styles panel
https://bugs.webkit.org/show_bug.cgi?id=218515

Attachment 414485: Patch

https://bugs.webkit.org/attachment.cgi?id=414485&action=review




--- Comment #53 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 414485
  --> https://bugs.webkit.org/attachment.cgi?id=414485
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414485&action=review

> Source/WebCore/platform/graphics/GlyphPage.h:110
>      Glyph glyph;
>      const Font* font;
> +
> +private:
> +    RefPtr<GlyphRange> m_range;

I don't really understand what this patch is doing but adding a refcounted
member to a performance critical low level type like GlyphData to support an
Inspector feature seems wrong. Please consider some other approaches. 

This shoudn't be landed as-is without review by Myles.


More information about the webkit-reviews mailing list