[webkit-reviews] review granted: [Bug 219092] check-webkit-style should require spaces around the equal sign for Objective-C @synthesize : [Attachment 414458] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Hoa Dinh <dvh at apple.com>'s
request for review:
Bug 219092: check-webkit-style should require spaces around the equal sign for
Objective-C @synthesize
https://bugs.webkit.org/show_bug.cgi?id=219092

Attachment 414458: Patch

https://bugs.webkit.org/attachment.cgi?id=414458&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 414458
  --> https://bugs.webkit.org/attachment.cgi?id=414458
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414458&action=review

> Tools/ChangeLog:6
> +	   Reviewed by NOBODY (OOPS!).

Ideally, there should be a sentence or two below the "Reviewed by" line
describing the change. Maybe something like along the lines of:

```
Teach the Objective-C style checker to prefer `@synthesize a = b` over
`@synthesize a=b`. As a followup,
<webkit.org/b/219094> will enforce this style rule in existing @synthesize
statements in WebKit.
```