[webkit-reviews] review granted: [Bug 218566] JSC build fails on Big Sur 11.0.1 beta : [Attachment 413183] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Sergey Rubanov
<chi187 at gmail.com>'s request for review:
Bug 218566: JSC build fails on Big Sur 11.0.1 beta
https://bugs.webkit.org/show_bug.cgi?id=218566

Attachment 413183: Patch

https://bugs.webkit.org/attachment.cgi?id=413183&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 413183
  --> https://bugs.webkit.org/attachment.cgi?id=413183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413183&action=review

r=me

> Source/cmake/WebKitFindPackage.cmake:94
> +	   # Apple just has a single tbd for ICU

Nit: Add period at the end of the comment.  (Not necessary to land, but you
might want to make this change while fixing the ChangeLog.)

> ChangeLog:8
> +	   * CMakeLists.txt:

Nit: Remove this line as this file is no longer changed.