[webkit-reviews] review granted: [Bug 218573] Non-fullscreen page contents visible when rotating device during element fullscreen presentation. : [Attachment 413186] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 4 11:21:33 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 218573: Non-fullscreen page contents visible when rotating device during
element fullscreen presentation.
https://bugs.webkit.org/show_bug.cgi?id=218573

Attachment 413186: Patch

https://bugs.webkit.org/attachment.cgi?id=413186&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 413186
  --> https://bugs.webkit.org/attachment.cgi?id=413186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413186&action=review

> Source/WebCore/css/fullscreen.css:36
> +    background-color: black !important;

A background-image could show over this.

> LayoutTests/fullscreen/full-screen-ancestor-overflow-layer-dump.html:29
> +		   setTimeout(() => {

Not sure if this will be reliable.


More information about the webkit-reviews mailing list