[webkit-reviews] review granted: [Bug 212386] Enhance Bitmap::setEachNthBit() to also take an end index. : [Attachment 400279] proposed patch.

[bugzilla-daemon at webkit.org]

Robin Morisset <rmorisset at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 212386: Enhance Bitmap::setEachNthBit() to also take an end index.
https://bugs.webkit.org/show_bug.cgi?id=212386

Attachment 400279: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=400279&action=review




--- Comment #3 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 400279
  --> https://bugs.webkit.org/attachment.cgi?id=400279
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=400279&action=review

r=me

> Source/WTF/wtf/Bitmap.h:436
> +    ASSERT(start <= end && end <= bitmapSize);

The first ASSERT is redundant, and I would split the other ASSERT into two for
better error messages.