[webkit-reviews] review granted: [Bug 212385] Add some new emitters to the X86_64 and ARM64 MacroAssemblers. : [Attachment 400277] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 26 15:06:29 PDT 2020
Robin Morisset <rmorisset at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 212385: Add some new emitters to the X86_64 and ARM64 MacroAssemblers.
https://bugs.webkit.org/show_bug.cgi?id=212385
Attachment 400277: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=400277&action=review
--- Comment #6 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 400277
--> https://bugs.webkit.org/attachment.cgi?id=400277
proposed patch.
View in context: https://bugs.webkit.org/attachment.cgi?id=400277&action=review
r=me
> Source/JavaScriptCore/ChangeLog:22
> + redundant null check.
Do we have any way of easily inserting an assert in the generated code when in
debug? It could be useful for these kind of things.
> Source/JavaScriptCore/assembler/testmasm.cpp:474
> + auto test = compile([=] (CCallHelpers& jit) {
what are you capturing by copy and why?
More information about the webkit-reviews
mailing list