[webkit-reviews] review granted: [Bug 212278] Make sure we clean up CFTimerRefs when destroying scrolling tree nodes : [Attachment 400073] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 13:59:38 PDT 2020


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 212278: Make sure we clean up CFTimerRefs when destroying scrolling tree
nodes
https://bugs.webkit.org/show_bug.cgi?id=212278

Attachment 400073: Patch

https://bugs.webkit.org/attachment.cgi?id=400073&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 400073
  --> https://bugs.webkit.org/attachment.cgi?id=400073
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400073&action=review

> Source/WebCore/page/scrolling/ScrollingTree.cpp:344
> +	   iter.value->willBeDestroyed();

This isn't going to mutate the map?


More information about the webkit-reviews mailing list