[webkit-reviews] review granted: [Bug 206052] Error sending IPC message: Broken pipe : [Attachment 400058] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 206052: Error sending IPC message: Broken pipe
https://bugs.webkit.org/show_bug.cgi?id=206052

Attachment 400058: Patch

https://bugs.webkit.org/attachment.cgi?id=400058&action=review




--- Comment #4 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 400058
  --> https://bugs.webkit.org/attachment.cgi?id=400058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400058&action=review

> Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:525
> +	   if (errno == EPIPE || errno == ECONNRESET) {

I would put the EPIPE check inside an OS(LINUX) guard, as it is clearly
something that is specific to the Linux kernel.

  #if OS(LINUX
      if (errno == ECONNRESET || errno == EPIPE)
  #else
      if (errno == ECONRESET)
  #endif
      {
	  // ...
      }