[webkit-reviews] review granted: [Bug 212243] iOS: Pressing tab in the Mail subject field moves focus to the body, but pressing shift tab doesn't move it back : [Attachment 400004] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 212243: iOS: Pressing tab in the Mail subject field moves focus to the
body, but pressing shift tab doesn't move it back
https://bugs.webkit.org/show_bug.cgi?id=212243

Attachment 400004: Patch

https://bugs.webkit.org/attachment.cgi?id=400004&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 400004
  --> https://bugs.webkit.org/attachment.cgi?id=400004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400004&action=review

> Source/WebCore/page/FocusController.cpp:453
> +    Document* document = focusedOrMainFrame().document();

I think we generally prefer the strong ref here, as it’s not clear that the
code below won’t nuke document.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:847
> +    TestWebKitAPI::Util::run(&delegate.get()->_done);

Nit - I don’t think you need the .get() here.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:862
> +    TestWebKitAPI::Util::run(&delegate.get()->_done);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:876
> +    TestWebKitAPI::Util::run(&delegate.get()->_didSendKeyEvent);

Ditto.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:878
> +    ASSERT_FALSE(delegate.get()->_done);

Ditto.