[webkit-reviews] review granted: [Bug 212253] Web Inspector: Storage: don't request the list of IndexedDB database names multiple times for the same security origin : [Attachment 400026] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 212253: Web Inspector: Storage: don't request the list of IndexedDB
database names multiple times for the same security origin
https://bugs.webkit.org/show_bug.cgi?id=212253

Attachment 400026: Patch

https://bugs.webkit.org/attachment.cgi?id=400026&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 400026
  --> https://bugs.webkit.org/attachment.cgi?id=400026
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400026&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +	   This can happen if additional frames are added that share the same
security origin as the
> +	   main frame. Simply maintain a `Set` of security origins that've
already been requested for
> +	   and ignore any repeat requests.

In general Storage probably doesn't respect the double key'd nature of storages
of (top frame, inner frame). But I think this is probably fine since the same
origin within two subframes is probably the same.