[webkit-reviews] review granted: [Bug 211724] stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js failing on ppc64le and s390x : [Attachment 399496] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 07:55:23 PDT 2020


Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 211724:
stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js
failing on ppc64le and s390x
https://bugs.webkit.org/show_bug.cgi?id=211724

Attachment 399496: Patch

https://bugs.webkit.org/attachment.cgi?id=399496&action=review




--- Comment #14 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 399496
  --> https://bugs.webkit.org/attachment.cgi?id=399496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399496&action=review

> Tools/Scripts/run-jsc-stress-tests:383
> +    # MIPS and PowerPC may are bi-endian. S390 (which includes S390x) is big
endian. The rest are little endian.

Please fix this comment.:

- # MIPS and PowerPC may are bi-endian. S390 (which includes S390x) is big
endian. The rest are little endian.
+ # MIPS and PowerPC may be little-endian or big-endian. S390 (which includes
S390x) is big-endian. The rest are little-endian.

MIPS can be little-endian or can be also big-endian.
The MIPS architecture variant we target our CI its MIPS32le (le stands for
little-endian).


More information about the webkit-reviews mailing list