[webkit-reviews] review granted: [Bug 194765] Animation of font-size with rem values is incorrect : [Attachment 399733] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 19 07:49:45 PDT 2020

Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 194765: Animation of font-size with rem values is incorrect

Attachment 399733: patch


--- Comment #10 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 399733
  --> https://bugs.webkit.org/attachment.cgi?id=399733

View in context: https://bugs.webkit.org/attachment.cgi?id=399733&action=review

> LayoutTests/animations/keyframe-rem-unit.html:20
> +    testRunner.waitUntilDone();
> +    await document.getAnimations()[0].finished;
> +    testRunner.notifyDone();

If you write an animation that use a rem unit in the "from" keyframe then you
could write this to only wait for the animation's "ready" promise which would
run the test one animation frame faster I think. Hopefully that works.

More information about the webkit-reviews mailing list