[webkit-reviews] review granted: [Bug 211735] Need to advertise support for WebP in the Accept header : [Attachment 399079] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 211735: Need to advertise support for WebP in the Accept header
https://bugs.webkit.org/show_bug.cgi?id=211735

Attachment 399079: Patch

https://bugs.webkit.org/attachment.cgi?id=399079&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 399079
  --> https://bugs.webkit.org/attachment.cgi?id=399079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399079&action=review

> Source/WebCore/loader/cache/CachedResourceRequest.cpp:135
> +#if !(HAVE(WEBP) || USE(WEBP))
> +    if (supportsVideoImage)
> +	   return
"image/webp,image/png,image/svg+xml,image/*;q=0.8,video/*;q=0.8,*/*;q=0.5"_s;
> +    return "image/webp,image/png,image/svg+xml,image/*;q=0.8,*/*;q=0.5"_s;
> +#else
> +    if (supportsVideoImage)
> +	   return
"image/png,image/svg+xml,image/*;q=0.8,video/*;q=0.8,*/*;q=0.5"_s;
> +    return "image/png,image/svg+xml,image/*;q=0.8,*/*;q=0.5"_s;
> +#endif

This is OK. I don’t know why you chose not the use the macros, but it’s fine.