[webkit-reviews] review granted: [Bug 211756] Fix build errors after r260992 : [Attachment 399082] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 11 20:33:16 PDT 2020
Darin Adler <darin at apple.com> has granted Yoshiaki Jitsukawa
<yoshiaki.jitsukawa at sony.com>'s request for review:
Bug 211756: Fix build errors after r260992
https://bugs.webkit.org/show_bug.cgi?id=211756
Attachment 399082: Patch
https://bugs.webkit.org/attachment.cgi?id=399082&action=review
--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 399082
--> https://bugs.webkit.org/attachment.cgi?id=399082
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=399082&action=review
> Source/JavaScriptCore/runtime/JSObject.h:1627
> + JSC_NATIVE_INTRINSIC_FUNCTION(jsName, cppName, (attributes), (length),
JSC::NoIntrinsic)
This is OK. Could also have written ::JSC::NoIntrinsic, which makes this work
even when inside a namespace that happens to have the identifier JSC in it.
More information about the webkit-reviews
mailing list