[webkit-reviews] review granted: [Bug 211655] Fix build errors and warnings for non-unified JSCOnly : [Attachment 398911] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 9 08:41:08 PDT 2020


Darin Adler <darin at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 211655: Fix build errors and warnings for non-unified JSCOnly
https://bugs.webkit.org/show_bug.cgi?id=211655

Attachment 398911: Patch

https://bugs.webkit.org/attachment.cgi?id=398911&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 398911
  --> https://bugs.webkit.org/attachment.cgi?id=398911
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398911&action=review

> Source/JavaScriptCore/tools/JSDollarVM.cpp:328
> +IGNORE_WARNINGS_BEGIN("unused-const-variable")

The need for this is unfortunate. Would be nice to find a way to avoid it.


More information about the webkit-reviews mailing list