[webkit-reviews] review granted: [Bug 211662] Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI : [Attachment 398920] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 211662: Remove HAVE_UI_SCROLL_VIEW_INDICATOR_FLASHING_SPI
https://bugs.webkit.org/show_bug.cgi?id=211662

Attachment 398920: Patch

https://bugs.webkit.org/attachment.cgi?id=398920&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 398920
  --> https://bugs.webkit.org/attachment.cgi?id=398920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398920&action=review

> Source/WebKit/ChangeLog:12
> +	   Remove this platform conditional and unconditionally use
-[UIScrolView _flashScrollIndicatorsForAxes:
> +	   persistingPreviousFlashes:]. All supported platforms with
UIScrollView have this SPI, and the conditional
> +	   was excluding Mac Catalyst, making WKKeyboardScrollViewAnimator send
a message to its scroll view that
> +	   is no longer implemented.

Seems like the headline here is fixing the bug on Mac Catalyst; a crash maybe?

Removing the HAVE macro is the less important half of this, as grateful as I am
to have that cleaned up too.