[webkit-reviews] review granted: [Bug 211274] Use LocalCurrentGraphicsContext in WebKit::convertPlatformImageToBitmap() : [Attachment 398315] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 211274: Use LocalCurrentGraphicsContext in
WebKit::convertPlatformImageToBitmap()
https://bugs.webkit.org/show_bug.cgi?id=211274

Attachment 398315: Patch v1

https://bugs.webkit.org/attachment.cgi?id=398315&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 398315
  --> https://bugs.webkit.org/attachment.cgi?id=398315
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=398315&action=review

> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:412
> +    {
> +	   LocalCurrentGraphicsContext savedContext(*graphicsContext);
> +	   [image drawInRect:NSMakeRect(0, 0, bitmap->size().width(),
bitmap->size().height()) fromRect:NSZeroRect
operation:NSCompositingOperationSourceOver fraction:1 respectFlipped:YES
hints:nil];
> +    }

We don’t really need the braces here since the scope only goes one line further
(after the return), but if you prefer it this way I am OK with it.