[webkit-reviews] review granted: [Bug 211353] Fix static analyzer false positive in -[WebUndefined undefined] : [Attachment 398317] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 3 16:18:52 PDT 2020

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 211353: Fix static analyzer false positive in -[WebUndefined undefined]

Attachment 398317: Patch v1


--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 398317
  --> https://bugs.webkit.org/attachment.cgi?id=398317
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=398317&action=review

> Source/WebCore/ChangeLog:11
> +	   - Use dispatch_once since iOS WK1 could initialize this on the
> +	     WebThread or the main thread.

Are you certain this is needed? I am concerned, because there are many things
that aren’t truly thread-safe that can go on either web thread of main thread.
And this seems like a speculative fix.

More information about the webkit-reviews mailing list