[webkit-reviews] review granted: [Bug 184529] atob() should not accept a vertical tab : [Attachment 398219] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 184529: atob() should not accept a vertical tab
https://bugs.webkit.org/show_bug.cgi?id=184529

Attachment 398219: Patch

https://bugs.webkit.org/attachment.cgi?id=398219&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 398219
  --> https://bugs.webkit.org/attachment.cgi?id=398219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398219&action=review

This change is OK, but I think it’s possibly needed because of a mistake.

> Source/WTF/wtf/text/Base64.cpp:213
> +		   || (!isSpaceOrNewline(ch) || ((options &
Base64DiscardVerticalTab) && ch == '\v'))) {

I don’t understand why we ever use the full-Unicode isSpaceOrNewline function.
In what context do we need to allow non-ASCII spaces? Do we have cross-browser
tests checking this behavior? What spaces exactly do we need to ignore? Does
any caller need ignore vertical tabs?